Web Hosting Vodahost    

Home Take The Royal Tour! Order Now Features Prices
Go Back   Web Hosting > VodaHost Web Hosting Support > mySQL & PHP

Notices

mySQL & PHP Discussions, information and help with mySQL and PHP.

Closed Thread
 
Thread Tools
  #1  
Old 07-23-2008, 03:55 AM
Sergeant
 
Join Date: Jun 2008
Posts: 25
Default Need help with WHILE statement

I am trying to display data from my tables using the following code but nothing is being displayed. I have verified that the data is there in the table inside the database. No echo statements within the while loop is executing. The code that I am using is;

?php
session_start();
$userId = $_SESSION['userId'];
$password = $_SESSION['password'];
$db_host= "localhost";
$db_user = "XXXX_YYYY";
$db_password = "ZZZZ";
$db_name ="XXXX_StudyKitchenData";
$db = mysql_connect($db_host, $db_user, $db_password);
mysql_select_db($db_name, $db);
$sql = "SELECT Email FROM UserDetails WHERE Email = '$userId' AND Password = '$password'";
$result = mysql_query($sql, $db);
if(!mysql_num_rows($result)== 1){
unset($_SESSION['userId'], $_SESSION['password']); // clear bad username/password from session;
header("location:http://www.studykitchen.com/login.php"); // redirect for them to login again
}
$query = "SELECT Page, Date, Time, ID FROM mydiary WHERE Email ='userId'";
$result = mysql_query($query, $db);
while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
//I did not get the following echo messages nor any error messages
echo "Date : ".$row['Date']." Time : ".$row['Time']." ID : ".$row['ID']." <br>" .
"".$row['Page']."<br>".
"".$row[<HR color="#0000ff" noshade size="5">]."<br><br>";
}
mysql_close($db);
?>

Please guide.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!Spurl this Post!Reddit! Wong this Post!
  #2  
Old 07-23-2008, 08:51 PM
Karen Mac's Avatar
General & Forum Moderator
 
Join Date: Apr 2006
Location: X marks the spot
Posts: 8,436
Send a message via MSN to Karen Mac
Default Re: Need help with WHILE statement

Im not an expert but.. shouldnt the result come after the FETCH or While?

Karen
__________________

VodaHost

Your Website People!
1-302-283-3777 North America / International
07031847328 / United Kingdom

Click Here to take the royal VodaHost Tour
Click Here for the VodaHost Help Centre & Tutorials
Got a question? - Try a forum search! Available at the top of every page!



Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!Spurl this Post!Reddit! Wong this Post!
  #3  
Old 07-24-2008, 10:30 AM
navaldesign's Avatar
General & Forum Moderator
 
Join Date: Oct 2005
Location: Italy
Posts: 10,542
Default Re: Need help with WHILE statement

add an error reporting line so you can see what is wrong (your code seems correct):


if (!$result){
echo "Error: ".mysql_error();
}

after

$result = mysql_query($query, $db);


If you get no echo at all, it meand that $result is not a valid MySQL resource. This can be due to many reasons. Generally speaking, you should be adding error reporting in all cases so that debugging will result easier.

And, i am allowed, your code is absolutely insecure and vulnerable to an injection attempt. If your final application is based on the above, hacking your MySQL will be quite easy.
__________________
Navaldesign
Logger Lite: Low Cost, Customizable, multifeatured Login script
Instant Download Cart: a Powerfull, Customized, in site, DB driven, e-products Cart
DBTechnosystems.com Forms, Databases, Shopping Carts, Instant Download Carts, Loggin Systems and more....
Advanced BlueVoda Form Processor : No coding form processor! Just install and use! Now with built in CAPTCHA!

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!Spurl this Post!Reddit! Wong this Post!
  #4  
Old 07-25-2008, 06:12 AM
Sergeant
 
Join Date: Jun 2008
Posts: 25
Default Re: Need help with WHILE statement

Navaldesign,

Again my grateful thanks to you for your guidance. I found the two syntax errors. I missed out the dollar sign in front of the variable in the query statement and didnot put the correct backslashes before defining the color for the horizontal line.

This is not my final application. Actually I am testing parts of it before I publish the whole website. Please do feel free to provide any suggestion/guidance to make my MYSQL more secure. You are way ahead of me in programming so any advice from you will be much appreciated.

I have just one more issue to resolve and then will be ready to publish the website. I will open another thread for it.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!Spurl this Post!Reddit! Wong this Post!
Closed Thread


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off



All times are GMT +1. The time now is 02:04 PM.


Powered by vBulletin® Version 3.8.4
Copyright ©2000 - 2010, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0 RC7
2005-2009 VodaHost Web Hosting Your Perfect Web Host - All Rights Reserved

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210